forked from JuliaData/DataFrames.jl
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstack in master expects sorted groups #1
Open
gustafsson
wants to merge
23
commits into
alyst:enhance_join
Choose a base branch
from
gustafsson:enhance_join
base: enhance_join
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use colordering(DFPerm) and getindex(DFPerm) to squeeze multiple lt() methods into one
- don't encode the indexing columns, use DataFrameRow hashes instead - do only the parts of left-right rows matching that are required for a particular join kind - avoid vcat() that is very slow for PooledDataVector - now join respects left-frame order for all join kinds, so the tests/data.jl test were updated
sorting order is changed from NA first to NA last (it matches the default data frame sorting)
so that DataFrameRow object doesn't need to be created
instead of using Dict{DataFrameRow,Int}, implement its own that - doesn't require DataFrameRow objects - calculates hashes in memory-efficient manner - keeps row hashes for efficient comparison use it for join(), groupby(), nonunique() disable DataFrameRowTests that use _RowGroupDict methods no longer available
it's not used and it is no loner faster than nonunique()
by default no sorting is applied to preserve original ordering (the initial order of the 1st rows is preserved) and make things faster
alyst
force-pushed
the
enhance_join
branch
2 times, most recently
from
October 4, 2016 22:19
d9cf89a
to
c53f3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch breaks the unit tests when merged to master on: https://github.com/JuliaStats/DataFrames.jl/blob/master/test/dataframe.jl
This commit preserves the expected behaviour of unstack to sort groups. It's probably a good idea to not sort groups, but if so that test needs to be updated as well.